Items.py Caching is slower than Uncached Version

Coffee-fueled-deadlines / OSRSBytes

OSRSBytes is an all-in-one Python library for Old School Runescape (OSRS) that features Item Information Lookup, OSRS Hiscores, and Grand Exchange Market information.

Eclipse Public License 2.0

49 stars 13 forks source link

Items.py Caching is slower than Uncached Version #6

Closed Coffee-fueled-deadlines closed 4 years ago

Coffee-fueled-deadlines commented 4 years ago

In OSRSBytes/Items.py on the dev branch, the new shelving method of caching information is much slower than the uncached version. Upon further research, apparently shelving is a bad method of caching large dictionary values. Instead, it may be worthwhile to look into implementing a SQLite3 caching method instead for the item section of this project.

Coffee-fueled-deadlines commented 4 years ago

Removed this feature for now.