CoffeeITWorks / ansible_burp2_server

Ansible role to deploy burp2 server
MIT License
10 stars 9 forks source link

Using copy instead of unarchive to deploy incexc files #96

Open ohmer1 opened 1 year ago

ohmer1 commented 1 year ago

I tried to edit incexc configuration files and wondered why the changes didn't apply to my server when running my playbook. I found two issues.

First issue, I found I had to edit the .tar.gz and not the incexc files directly. It's confusing and error prone I think (At first, I edited the individual file without reading the task file). I proceed to edit the .tar.gz anyway. I ran the playbook again and still no apply. The second issue I found is caused by the created parameter used in the task, Ansible never updates the directory again if incexc/audio_exclusions exists at the remote server.

I propose to use the copy module instead of the unarchive module to update theses file. The directory doesn't content a lot of files, so there is not much performance penalty.