search

CoffeeWithDevs / CodeWithUs

Code with Us is an Organisation for university students who want to bring about a change through technology. We are focused upon building technical and non-technical skills, which would help students to build a better community
https://coffeewithdevs.github.io/CodeWithUs/
5 stars 19 forks source link

Add responsive nav-bar #25

Closed ka-hn closed 3 years ago

ka-hn commented 3 years ago

This will add responsive navigation bar. See example images below.

Fixes issue #18

Desktop OLD Desktop-Nav-Bar-Old

Desktop NEW Desktop-Nav-Bar-New

Mobile OLD Mobile-Nav-Bar-Old

Mobile NEW Collapsed Mobile-Nav-Bar-New-Collapsed

Mobile NEW Expanded Mobile-Nav-Bar-New-Expanded

kumarmanish03 commented 3 years ago

@ka-hn Great Work!!! Keep contributing

kumarmanish03 commented 3 years ago

Hey @ka-hn, when I merged your pr there are some issues with the navbar, it was not showing the hamburger icon So I revert the changes and then some hell happens as can see on live site Now, your task is to fix the current bug to the original one you created PS: Resolve this as soon as possible

ka-hn commented 3 years ago

@kumarmanish03

I will look into it, however since it's reverted I cannot reproduce (the unresponsive one is on the live site) but I will try again and see if I can find the issue somehow

kumarmanish03 commented 3 years ago

@ka-hn Also update your cloned repo with the remote before making any changes

ka-hn commented 3 years ago

@kumarmanish03 I have recreated everything now and on my side I cannot se any bug at all. Can you please explain what the bug is / was?

The Hamburger menu is supposed to appear when you are only on mobile devices. Do you want the hamburger menu to be persistent at all times?

kumarmanish03 commented 3 years ago

No, I only want Hamburger menu for mobile devices only. Now, make a separate PR of your changes Also create gh-page of your forked repo for easy reviewing