Coflnet / SkyModCommands

Backend for minecraft frontend
GNU Affero General Public License v3.0
4 stars 3 forks source link

Better or more consistent "createAuction" slot identifier #82

Closed matthias-luger closed 1 year ago

matthias-luger commented 1 year ago

Currently there is the itemName property on the data that is sent with the "createAuction" command.

Most of the time the itemName property is the displayName property of the slot in the Inventory. This is not the case for some items (I noticed it with pets):

The Name property inside the nbt-data also doesnt work for that, because it includes the color codes, which I would need to remove. => Also not a clean solution

The best case in by opinion would be to

A) Respond with "Head" for pets and B) Also add the uuid to createAuction. If I remember correctly, there are things without a UUID, like stackable items. If there is no uuid I would just check the displayName. Otherwise I can just check the uuid.

Ekwav commented 1 year ago

The itemName is/was always the displayName uploaded. I Added Id which is the uuid or Tag of the item if no uuid is found. I also updated the name to be the one from hypixel nbt