/crafts always try to find auctions

Coflnet / hypixel-react

GNU Affero General Public License v3.0

8 stars 17 forks source link

/crafts always try to find auctions #1249

Open Ekwav opened 4 months ago

Ekwav commented 4 months ago

It opens https://sky.coflnet.com/item/ENCHANTED_DIAMOND_BLOCK?itemFilter=eyJCaW4iOiJ0cnVlIn0%3D&range=active which doesn't display bazaar graphs. Either the craft section should change the link or the bazaar view should not care about the active option and default to day

matthias-luger commented 4 months ago

fixed by d4166cbe724a469f0f5772631c2e72e1bdabbe90

Ekwav commented 4 months ago

When it is an auction it should still focus the active tab as the user may want to see what the cheapest available auction is. So this change broke that behavior. Should I maybe add an endpoint that contains a command for getting to the item (bazaar for bazaar items and /viewauction for ah) Would replace the craft recipe endpoint (also return the recipe) and called when a user clicks to see the detailed view

matthias-luger commented 4 months ago

Yes, that would be a good idea :)

matthias-luger commented 4 months ago

@Ekwav Is there already an issue for this?