Cog-Creators / Red-DiscordBot

A multi-function Discord bot
https://docs.discord.red
GNU General Public License v3.0
4.83k stars 2.3k forks source link

[Downloader] `[p]findcog` won't properly display author and repo. #3370

Open Dav-Git opened 4 years ago

Dav-Git commented 4 years ago

Command bugs

Command name

[p]findcog <not_a_core_cog_command>

What cog is this command from?

Downloader

What were you expecting to happen?

Expecting it to show cog name, author name and repo the command is from.

What actually happened?

Only shows cog name.

How can we reproduce this issue?

Load a 3rd party cog and use [p]findcog with one of it's commands.

Additional info

This is happening on a bot that was updated to 3.2.2. Maybe there's an issue wih updated bots only as some behaviour with the Downloader cog has been weird since the update. The message says that the repo the command originated from is "Missing from installed repos".

grafik

Dav-Git commented 4 years ago

Has something to do with me doing a system change under 3.1 and not installing repos with the same names as on my previous machine. Thanks Jackenmen

Jackenmen commented 4 years ago

To clarify, this might have looked somehow like this (commands ran on 3.1 instance):

  1. [p]repo add SinbadCogs https://github.com/mikeshardmind/SinbadCogs
  2. [p]cog install SinbadCogs scheduler
  3. [p]repo delete SinbadCogs
  4. [p]repo add sinbad https://github.com/mikeshardmind/SinbadCogs
  5. [p]cog install sinbad scheduler

Then after this, update to 3.2 at some point.

Of course in Dav's case all those commands weren't just all run one by one, but over the course of time but that is how you could most likely reproduce this.

Edit: it might be worth addressing in some way in a form of warning about dangling cogs when [p]cog update is ran, but it isn't very important

Dav-Git commented 4 years ago

How it went for me:

  1. Setup redbot for the first time in my life
  2. [p]repo add SinbadCogs https://github.com/mikeshardmind/SinbadCogs
  3. [p]cog install SinbadCogs scheduler
  4. [p]backup
  5. Change machine, load a backup of red.
  6. [p]repo add sinbad https://github.com/mikeshardmind/SinbadCogs
  7. [p]cog install sinbad scheduler

So this should in theory apply to everyone who loaded a backup in the 3.1 times.

If you guys think handling in some form isn't needed just close the issue.