Cog-Creators / Red-DiscordBot

A multi-function Discord bot
https://docs.discord.red
GNU General Public License v3.0
4.81k stars 2.31k forks source link

[Audio] Local tracks with special characters in path wont return a value in all cases #3467

Closed ltukezl closed 4 years ago

ltukezl commented 4 years ago

Command bugs

Command name

[p]local folder [p]local play

What cog is this command from?

audio

What were you expecting to happen?

trying to play a folder with spaces in path such as: https://puu.sh/F4B4A/9070d830aa.png and selecting 2

should result in playing all songs inside that folder

What actually happened?

Nothing found message. http://puu.sh/F4B5s/45eb04af34.png

How can we reproduce this issue?

make (symlink) folder. add another folder inside it with a space in name. "redbot test" and try to play it.

Drapersniper commented 4 years ago

Blocked by #3459

Drapersniper commented 4 years ago

@ltukezl I'm unable to reproduce this any longer ...

image image

Is this still an issue for you if it is please post the output of [p]audioset settings and [p]debuginfo

ltukezl commented 4 years ago

Folders with only spaces do work now. folders with "[]" doesn't work for example "tst 1 [tst]" still gives "Nothing found". maybe other special markings too but didn't test others.

----Server Settings----
Auto-disconnect: [Disabled] Auto-play: [Disabled] Repeat: [Disabled] Shuffle: [Disabled] Shuffle bumped: [Enabled] Song notify msgs: [Disabled] Songs as status: [Disabled]

---Cache Settings---
Max age: [365 days] Spotify cache: [Disabled] Youtube cache: [Disabled] Lavalink cache: [Disabled]

---Lavalink Settings---
Cog version: [1.1.1] Red-Lavalink: [0.4.2] External server: [Disabled] Localtracks path: [E:\red-musicbot\cogs\Audio]

Red version 3.3.1 Python version 3.8.1 (64bit) Discord.py version 1.3.1 Pip version 20.0.2 System arch AMD64 OS version Windows 10 (version 10.0.17134) Python executable c:\python38\python.exe

Drapersniper commented 4 years ago

Will be fixed as part of the next Audio update

Drapersniper commented 4 years ago

This has been fixed in the feature branch