Cog-Creators / Red-DiscordBot

A multi-function Discord bot
https://docs.discord.red
GNU General Public License v3.0
4.76k stars 2.3k forks source link

Use YouTube source plugin over the deprecated built-in source #6373

Closed Jackenmen closed 2 months ago

Jackenmen commented 5 months ago

Description of the changes

This PR switches our auto-generated Lavalink application.yml file to use the YouTube source plugin over the deprecated built-in source. The proposed implementation does not define this plugin in the Config defaults under the yaml key and instead dynamically generates it in the ServerManager.process_settings() method. The upsides here are:

The downside is that the defaults are no longer placed in a single spot. It is not ideal but there's a need for some redesign to support plugins anyway so I figure this is likely a better solution, at least for now.

Have the changes in this PR been tested?

Yes

aikaterna commented 4 months ago

Do you think it would be worth having an info level log line on what plugins it's downloading, similar to other log lines exposed on audio/Lavalink.jar startup? Thinking of any potential support info needed there.