search

CogComp / cogcomp-datastore

A convenient wrapper for interfacing minio java api
1 stars 2 forks source link

Ignore credentials when initializing with ResourceManager #5

Open Slash0BZ opened 7 years ago

Slash0BZ commented 7 years ago

I am not sure if it's intended to, but https://github.com/CogComp/cogcomp-datastore/blob/b482264f7e6a1e6f34d14100b243e8f6131ad49e/src/main/java/org/cogcomp/Datastore.java#L120-#L128

Here the constructor Datastore(ResourceManager) only check and load endpoint and ignore other properties.

I can change that if you want.

danyaljj commented 7 years ago

Here it was intended, since we (at least me) use this constructor only in cogcomp-nlp and there it's always for reading files and not writing anything. You can extend it though.