search

CogComp / cogcomp-nlp

CogComp's Natural Language Processing Libraries and Demos: Modules include lemmatizer, ner, pos, prep-srl, quantifier, question type, relation-extraction, similarity, temporal normalizer, tokenizer, transliteration, verb-sense, and more.
http://nlp.cogcomp.org/
Other
471 stars 142 forks source link

Use URIs not filepaths #192

Open cowchipkid opened 8 years ago

cowchipkid commented 8 years ago

Files on a file system can be represented in the same way documents within jar files can using a URI. This would make it easier to use normalize path separators. This would be a very big change.

qiangning commented 8 years ago

Hi @cowchipkid , I was just gonna change this line before I saw your comment since it is returning a null pointer while testFileName actually exists. Do you want us to keep the original way (i.e., using URLs)? Do you have any ideas about why it gives me a null?

cowchipkid commented 8 years ago

testFileName is expected to be a path within a jar file (or folder) that is in the JVM's class path. This will not find a file in the file system, unless it is in the classpath and under the directory structure reflected by the path in testFileName.

qiangning commented 8 years ago

Thanks a lot, Tom!