Implement test case for IOUtils.java (and ideally everything else)

CogComp / cogcomp-nlp

CogComp's Natural Language Processing Libraries and Demos: Modules include lemmatizer, ner, pos, prep-srl, quantifier, question type, relation-extraction, similarity, temporal normalizer, tokenizer, transliteration, verb-sense, and more.

http://nlp.cogcomp.org/

Other

473 stars 142 forks source link

Implement test case for IOUtils.java (and ideally everything else) #224

Open haowu40 opened 8 years ago

haowu40 commented 8 years ago

Many resources related functions are obscure and hard to reason with. (Jar file handling, Windows issues). For example, without an unit-test, I almost made a mistake by connecting JarEntry with Windows File.SEPARATOR.

Without unit-test, no one can be 100% sure if we are fixing bugs or introducing more.

We should at least have unittest for those tricky functions and critical ones. And I suggest we add a Corveralls service to monitor the progress. Also, otherwise we are not taking the full advantage of CI.

haowu40 commented 8 years ago

Also, does Semaphore provide Windows env testing?

danyaljj commented 8 years ago

does Semaphore provide Windows env testing?

it does not. But @bhargav has installed AppVoyer which has Win env.

bhargav commented 8 years ago

Yes. I have setup Windows CI to only build changes to the master branch. Currently the unit tests fail. It might be good to (spend some time to) debug in some Windows machine once and make sure we do not regress.

https://ci.appveyor.com/project/bhargavm/illinois-cogcomp-nlp

danyaljj commented 8 years ago

@haowu4 are you planning to address this issue yourself?

mssammon commented 8 years ago

@haowu4 let me know if you want to break this up into multiple smaller issues