search

CogComp / cogcomp-nlp

CogComp's Natural Language Processing Libraries and Demos: Modules include lemmatizer, ner, pos, prep-srl, quantifier, question type, relation-extraction, similarity, temporal normalizer, tokenizer, transliteration, verb-sense, and more.
http://nlp.cogcomp.org/
Other
473 stars 142 forks source link

[pipeline] Don't need to specify the annotators? #418

Open danyaljj opened 7 years ago

danyaljj commented 7 years ago

Now that loading the models in annotators is lazy, I suppose we don't need these if-elses? https://github.com/CogComp/cogcomp-nlp/blob/master/pipeline/src/main/java/edu/illinois/cs/cogcomp/pipeline/main/PipelineFactory.java#L183-L284

mssammon commented 7 years ago

This is true for some annotators, but not others (Stanford components are not lazily loaded, and possibly some CCG annotators)

danyaljj commented 7 years ago

Relevant to this why can't we make our dependency and Stanford components lazy? https://github.com/CogComp/cogcomp-nlp/blob/master/depparse/src/main/java/edu/illinois/cs/cogcomp/depparse/DepAnnotator.java#L37-L42