CogComp / cogcomp-nlp

CogComp's Natural Language Processing Libraries and Demos: Modules include lemmatizer, ner, pos, prep-srl, quantifier, question type, relation-extraction, similarity, temporal normalizer, tokenizer, transliteration, verb-sense, and more.
http://nlp.cogcomp.org/
Other
470 stars 144 forks source link

Added the ability to use JSON Serialized Format with NerTagger #676

Closed mayhewsw closed 6 years ago

mayhewsw commented 6 years ago

Now you can load JSON-Serialized TextAnnotation files from NerTagger. Before you could only use column format (-c) or bracket format (-r), and column format was hard coded.

cowchipkid commented 6 years ago

@danyaljj @mssammon think this changeset will conflict with the change set I am working right now. And since I just jumped through hoops to fix a merge gone terribly awry, I am going approve this merge, which looks fine, and merge trunk again to my branch to make sure the merge actually works this time. @danyaljj I have one day left, so please rush this PR review. @mayhewsw Kudos on actually commenting your code. Let's defer my PR till this one makes it to trunk.

danyaljj commented 6 years ago

Looks good to me. Will merge upon TC turning green.