search

CogComp / cogcomp-nlp

CogComp's Natural Language Processing Libraries and Demos: Modules include lemmatizer, ner, pos, prep-srl, quantifier, question type, relation-extraction, similarity, temporal normalizer, tokenizer, transliteration, verb-sense, and more.
http://nlp.cogcomp.org/
Other
470 stars 144 forks source link

NER: fail to read training data to train model #691

Closed yxd126 closed 5 years ago

yxd126 commented 6 years ago

Don't know who changed the code. When using NerBenchmark to train the model, the current NER cannot read training data from a folder to train a new model. I already find out the reason. The parameter order here is: getLearningCurve(fixedNumIterations, trainDataPath, "-c", testDataPath, incremental); (https://github.com/CogComp/cogcomp-nlp/blob/master/ner/src/main/java/edu/illinois/cs/cogcomp/ner/LbjTagger/LearningCurveMultiDataset.java#L76)

But the parameter order here is: public static void getLearningCurve(int fixedNumIterations, String dataFormat, String trainDataPath, (https://github.com/CogComp/cogcomp-nlp/blob/master/ner/src/main/java/edu/illinois/cs/cogcomp/ner/LbjTagger/LearningCurveMultiDataset.java#L94)

'-c' and trainDataPath should change their position.

@mssammon @cowchipkid

cowchipkid commented 6 years ago

I saw that as well, and I have fixed it. I discovered when testing the new set of changes to support multiple models in the same process space. I will check all that in today and issue a PR.

yxd126 commented 5 years ago

I have checked again, and the issue has been solved.