search

CogComp / cogcomp-nlp

CogComp's Natural Language Processing Libraries and Demos: Modules include lemmatizer, ner, pos, prep-srl, quantifier, question type, relation-extraction, similarity, temporal normalizer, tokenizer, transliteration, verb-sense, and more.
http://nlp.cogcomp.org/
Other
470 stars 144 forks source link

readme update for memory usage of Verb SRL in pipeline (close #656); ChunkerTrain bug fixed and model updated (close #685) #694

Closed qiangning closed 5 years ago

qiangning commented 5 years ago

After investigation of the memory usage of Verb SRL in our pipeline, I suggest that we close #656 with a few notes added in README.

qiangning commented 5 years ago

Note: I'm working on two issues and they got merged into this single PR.

The first commit of readme update for memory usage... is to close #656. This is straightforward: I'm adding a few lines in the readme file of pipeline to clarify the memory usage of VerbSRL.

The other three commits are to close #685. I fixed the bug of ChunkerTrain that it wrongly loads pretrained models when training a new one. I then retrained the model and found that the performance got slightly improved. So I deployed the new model to here and changed the code accordingly.

mssammon commented 5 years ago

@qiangning looks like CI build is failing -- please take a look.

qiangning commented 5 years ago

It should be that the mvn test failed. I'm working on it.

cogcomp-dev commented 5 years ago

@qiangning CI test is failing because chunker output has changed, and the test diffs it with a reference output. Please update the test files and this should be good to go.

qiangning commented 5 years ago

Thanks. Yes, I found it. Plan to work on it tonight.

qiangning commented 5 years ago

All the tests have passed. If no objections, I'll merge it sometime late tonight.