Not everything should be a property in TextAnnotation

CogComp / cogcomp-nlpy

CogComp's light-weight Python NLP annotators

http://nlp.cogcomp.org/

Other

116 stars 26 forks source link

Not everything should be a property in TextAnnotation #112

Open shyamupa opened 6 years ago

shyamupa commented 6 years ago

ta.get_pos and ta.get_ner should be vanilla methods instead of being properties.

For properties, I suggest have ta.pos and ta.ner if we want that functionality.

nitishgupta commented 6 years ago

I also agree with Shyam. I don't see a point of having ta.pos style properties. Just functions should suffice. But, if we do so now, a lot of old code will break. What should we do. I don't know of code apart from Lorelei and My-EL that uses cogcomp-nlpy. So this might be a good time before more people start to use this.