search

CogComp / illinois-sl

A general-purpose Java library for performing structured learning.
Other
22 stars 10 forks source link

License #1

Closed danyaljj closed 8 years ago

danyaljj commented 8 years ago

Although in the readme you say it is released under academic license, the actual repo contains NCSA license: https://github.com/IllinoisCogComp/illinois-sl/blob/master/LICENSE I think you should replace with this: https://github.com/IllinoisCogComp/lbjava/blob/master/LICENSE

danyaljj commented 8 years ago

Also a suggestion: lbjava project uses the license maven plugin to add a small snippet on top of each file: https://github.com/IllinoisCogComp/lbjava/blob/master/pom.xml#L90-L119

danyaljj commented 8 years ago

FYI @shyamupa

shyamupa commented 8 years ago

I need to discuss this with Dan and Kai-Wei. Thanks for bringing to notice!

KaiWeiChang commented 8 years ago

Hi Shyam, As long as it can be recognised as open source license (http://www.opensource.org/licenses/), I'm fine with it. Could you talk to Dan or Mark and see what we should use?

Thanks for the pointer of maven plugin.

shyamupa commented 8 years ago

Mark says its open source. I am closing this.