The Lexicon class is not thread safe

CogComp / lbjava

Learning Based Java (LBJava)

http://cogcomp.cs.illinois.edu/page/software_view/LBJava

Other

13 stars 17 forks source link

The Lexicon class is not thread safe #15

Closed cowchipkid closed 8 years ago

cowchipkid commented 8 years ago

still not, but added code to construct the lexicon hash map as soon as data is loaded. This serves to fix the problem for NER.

christos-c commented 8 years ago

@cowchipkid is this a work-in-progress PR, or is it the final fix? If so, change "partially addresses" to "fixes" in the description.

cowchipkid commented 8 years ago

This change fixes the issue with NER, but depending on how the Lexicon class is used, others will likely encounter problems, particularly when running multi-threaded. i have marked this as fixes, but it fixes the issue with NER, the core issue remains. I issued a bug (#14) on this issue.