search

CogComp / lbjava

Learning Based Java (LBJava)
http://cogcomp.cs.illinois.edu/page/software_view/LBJava
Other
13 stars 17 forks source link

updated doc; added tutorial for regression; added class TestReal #22

Closed yj14n9xyz closed 8 years ago

yj14n9xyz commented 8 years ago

@christos-c @danyaljj This PR is to update the doc and add a tutorial.

The actual example will be added in a later PR.

yj14n9xyz commented 8 years ago

@danyaljj Thanks for pointing out grammar errors. Please review the changes.

danyaljj commented 8 years ago

Thanks. Looks good to me @yimingjiang ! :) We can merge it when @christos-c gives the green light.

christos-c commented 8 years ago

I'm ok for this to merge @yimingjiang, @danyaljj. But I do worry about adding documentation about code that doesn't yet exist (like TestReal). Could we not add this class first and then merge this?

yj14n9xyz commented 8 years ago

@christos-c @danyaljj Hi Christos and Daniel, I have added the TestReal class. Please review the update.

danyaljj commented 8 years ago

Looks good to me.

yj14n9xyz commented 8 years ago

@danyaljj Hi Daniel, thanks for reminding to update the doc, since I changed the interface a little bit. Please review the new changes.

yj14n9xyz commented 8 years ago

@danyaljj Please review all new changes. I have added an empty Algorithms file. It's going to be filled once the algo tests are finished.

danyaljj commented 8 years ago

Looks good!

yj14n9xyz commented 8 years ago

@danyaljj Thanks!