CogComp / lbjava

Learning Based Java (LBJava)
http://cogcomp.cs.illinois.edu/page/software_view/LBJava
Other
13 stars 17 forks source link

OJalgoHook is too verbose #24

Closed christos-c closed 8 years ago

christos-c commented 8 years ago

There are lots of print statements that need to be delegated to a debug mode. Also, "Good news!: the optimizatin solution is optimal" 1) too informal 2) contains a spelling error (IntelliJ catches these :smile:)

danyaljj commented 8 years ago

I removed some annoying comments in #19, which will appear in the next release.

About "Good news! ...": I like it! :D If you don't like it, go to here and press the button.

Will fix the spelling errors.

christos-c commented 8 years ago

I think you still have some annoying comments left. Here is just one small run of my ESRL system:

Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! Good news!: the optimizatin solution is optimal! 292 examples tested at Mon Jan 25 14:27:53 CST 2016

Average evaluation time: 3.595890410958904E-4 seconds

Are you annoyed yet? :smile:

danyaljj commented 8 years ago

I'm glad you are seeing so many good news! :D

danyaljj commented 8 years ago

I'll drop the output.

danyaljj commented 8 years ago

BTW, does it work reasonably? How slower do you think it is, compared to Gurobi?

christos-c commented 8 years ago

I can't see a difference, in performance, but maybe this is too small of a problem. The scores are even slightly better (but I don't think there is a statistically significant difference there).

cowchipkid commented 8 years ago

Don’t know how voluminous that output is, but I have seen systems spend the majority of their time doing logging, so performance might be measured more accurately when you disable that output.

On Jan 25, 2016, at 2:34 PM, Christos Christodoulopoulos notifications@github.com wrote:

I can't see a difference, in performance, but maybe this is too small of a problem. The scores are even slightly better (but I don't think there is a statistically significant difference there).

— Reply to this email directly or view it on GitHub https://github.com/IllinoisCogComp/lbjava/issues/24#issuecomment-174654052.

danyaljj commented 8 years ago

All done in the most recent reply a few mins ago.