search

CogComp / lbjava

Learning Based Java (LBJava)
http://cogcomp.cs.illinois.edu/page/software_view/LBJava
Other
13 stars 17 forks source link

added regression example and fixed script issue #37

Closed yj14n9xyz closed 8 years ago

yj14n9xyz commented 8 years ago

@christos-c @danyaljj

I have fixed the script issue and added the regression example. Code are documented and data set is cited and documented. All other examples compiled successfully.

yj14n9xyz commented 8 years ago

@christos-c @danyaljj

I wonder why semaphore build failed. My guess is that to compile all examples, the script is now sh compileLBJ.sh all rather sh compileLBJ.sh.

The alternative is that we keep sh compileLBJ.sh as the command to build all, so we don't have to change the semaphore side.

danyaljj commented 8 years ago

I have invited you to the Semaphore. You can login and see the log.

yj14n9xyz commented 8 years ago

@christos-c @danyaljj It turns out that I need to add the license header for code. Thanks for changing the script on Semaphore @danyaljj . Now build succeeded. Please review this PR.

danyaljj commented 8 years ago

Thanks @yimingjiang I will go through the details.

danyaljj commented 8 years ago

Looks good to me. Passing the torch to @christos-c .

christos-c commented 8 years ago

@yimingjiang looks good. Once you address mine and @danyaljj issues he can merge.

yj14n9xyz commented 8 years ago

@danyaljj @christos-c I have resolved issues and updated with the repo. Also I have checked that the example runs as expected. Please review the changes.