search

CogComp / lbjava

Learning Based Java (LBJava)
http://cogcomp.cs.illinois.edu/page/software_view/LBJava
Other
13 stars 17 forks source link

copy dependencies necessary for java-cup? #77

Closed danyaljj closed 8 years ago

danyaljj commented 8 years ago

The comment here says the copy-dependencies stage is necessary for java cup. I commented it out and ran mvn test and nothing broke. Is it fine to drop this goal?

Why am I asking this?: suppose we add another module, on which lbjava depends (e.g. inference). If the dependency is not already deployed, copy-dependencies would fail.

christos-c commented 8 years ago

I would be happy to drop this if you make sure it doesn't affect the compilation of the language itself (yylex and parser), neither of which will show in the test phase unless you start completely from scratch (clean computer, clean repo).

christos-c commented 8 years ago

I take it this is no longer a problem @danyaljj?