search

CogComp / lbjava

Learning Based Java (LBJava)
http://cogcomp.cs.illinois.edu/page/software_view/LBJava
Other
13 stars 17 forks source link

Made `setWeight` public #85

Closed christos-c closed 8 years ago

christos-c commented 8 years ago

Closes #84

kordjamshidi commented 8 years ago

Thanks a lot, should I wait for @danyaljj to merge?

christos-c commented 8 years ago

This is a minor change with no adverse effects that I can see. It's fine with me if you just merge, but please remember to run sh increment-pom-versions.sh, push to master directly (the updated poms) and mvn deploy it. Thanks.

kordjamshidi commented 8 years ago

could you please make the version change as well? (I mean the steps @christos-c mentions.)

christos-c commented 8 years ago

done. but I cannot mvn deploy, you need to do that (after pulling the latest from the main fork)

kordjamshidi commented 8 years ago

@danyaljj could you help with deploying?

kordjamshidi commented 8 years ago

@danyaljj, @christos-c , I did deploy to mvn repo, though I still do not see it there. Thanks.

christos-c commented 8 years ago

Have you checked the permissions?

kordjamshidi commented 8 years ago

yes, it seems the problem is with the permissions.

kordjamshidi commented 8 years ago

it would be helpful if someone can make the deploy instead of me.

christos-c commented 8 years ago

Version 1.2.24 is now deployed