search

CogComp / saul

Saul : Declarative Learning-Based Programming
Other
64 stars 18 forks source link

getRelatedFieldsBetween #119

Open kordjamshidi opened 8 years ago

kordjamshidi commented 8 years ago

This deprecated function does not work properly: https://github.com/IllinoisCogComp/saul/blob/master/saul-core/src/main/scala/edu/illinois/cs/cogcomp/saul/datamodel/DataModel.scala#L90 and this leads to the ER not to work now. Because this feature uses that: https://github.com/IllinoisCogComp/saul/blob/master/saul-examples/src/main/scala/edu/illinois/cs/cogcomp/saulexamples/nlp/EntityMentionRelation/entityRelationClassifiers.scala#L29 @sameersingh , is it relevant to your changes? Could you have a look?

kordjamshidi commented 8 years ago

And the same with this feature : https://github.com/IllinoisCogComp/saul/blob/master/saul-examples/src/main/scala/edu/illinois/cs/cogcomp/saulexamples/nlp/EntityMentionRelation/RewriteBasicModel/entityRelationBasicDataModel.scala#L78, with getWithWindow.