_atMost and _atLeast constraints do not function correctly.

CogComp / saul

Saul : Declarative Learning-Based Programming

Other

64 stars 18 forks source link

_atMost and _atLeast constraints do not function correctly. #147

Open kordjamshidi opened 8 years ago

kordjamshidi commented 8 years ago

I use _atMost for SRL model, for some cases I got NPE for Unsatisfied constraints. An now testing on setcover case, replacing _forAll with atLeast(1) I see again constraints are not satisfiable. So there should be a bug. Checking ...

kordjamshidi commented 8 years ago

It seems these two, particularly, are only evaluation rather than generation. @haowu4

danyaljj commented 8 years ago

@kordjamshidi I couldn't find any easy solution for this. The only thing that comes to my mind is re-implementation of LBJava AtLeastQuantifier which gets a sensor Object => FirstOrderConstraint (rather than a single FirstOrderConstraint), which demands non-trivial amount of work.

Given that I have was focused on Saul for the past couple of weeks, I am very much behind other project. If you need this for IJCAI, feel free to assign it to someone else. Otherwise I am happy to give it another try after mid-Feb.

danyaljj commented 8 years ago

Nevermind; stayed up and finished it. Updated the PR #178.

kordjamshidi commented 8 years ago

This is great, many thanks. Given that the last couple of weeks I did not hear from you!

kordjamshidi commented 8 years ago

For solving this, might be useful to look at this paper: http://cogcomp.cs.illinois.edu/page/publication_view/169