search

CogComp / saul

Saul : Declarative Learning-Based Programming
Other
64 stars 18 forks source link

ClassifierUtils: saving, testing, etc made generic #272

Closed danyaljj closed 8 years ago

danyaljj commented 8 years ago

Closes #259 FYI: @kordjamshidi

kordjamshidi commented 8 years ago

I think we should be consistent and have all in the same way implemented to be able to receive different types, what others think?

danyaljj commented 8 years ago

I don't have any strong opinions on this; I merged them.

kordjamshidi commented 8 years ago

My comment is not addressed, yet!

danyaljj commented 8 years ago

Be specific; please comment on the line which contains the issue; otherwise I don't know what you are talking about...

kordjamshidi commented 8 years ago

This was assigned to @bhargav and I had a comment on it!

kordjamshidi commented 8 years ago

Specific about what? you know what was my comment.

danyaljj commented 8 years ago

please comment on the line which contains the issue

kordjamshidi commented 8 years ago

@bhargav if this is ok could you merge it please?

kordjamshidi commented 8 years ago

thanks!