CogComp / saul

Saul : Declarative Learning-Based Programming
Other
64 stars 18 forks source link

ConstrainedClassifier should receive node #322

Open kordjamshidi opened 8 years ago

kordjamshidi commented 8 years ago

After the latest changes for using nodes instead of the whole datamodel, it seems one thing has left without being updated, that is, ConstrainedClassifier. I think @bhargav was completing these related changes so assigned to him.

bhargav commented 8 years ago

Christos's changes removed the DataModel instance that was passed into ConstrainedClassifier. In the current implementation, ConstrainedClassifier uses either pathToHead or the onClassifier instance to get its training/testing data. There is no need to explicitly provide a node.