CogComp / saul

Saul : Declarative Learning-Based Programming
Other
64 stars 18 forks source link

DataModel Classes vs. Objects #325

Closed kordjamshidi closed 8 years ago

kordjamshidi commented 8 years ago

Though our Learnables are node based now, we need to import our data model object in the global object that contains all our classifiers. So, if we want to use the classifiers for a different data model object we need to change the import line in there. This is problematic for some cases, for example in SRL the test units use a different data model compared to the SRLApp -this is also because the data model class is parametrized differently for those two. The problem then is that we either need to duplicate the classifiers file or set it in a way that only the test units work. In this case, if the user wants to run the SRLApp he/she should change the import line in the classifiers object otherwise the SRLApp will not work. Any idea how to solve this? see my test draft in here: https://github.com/IllinoisCogComp/saul/pull/136#discussion-diff-66158292R25