search

CogComp / saul

Saul : Declarative Learning-Based Programming
Other
64 stars 18 forks source link

Documentation for declaring a class of learners based on parameterized properties. closes issue #297. #332

Closed kordjamshidi closed 8 years ago

danyaljj commented 8 years ago

I think the example is a little too complicated for someone who's learning. Why not make it a little simpler, like the following: 

 class DrugResponseRegressor(inputFeatures: Property[PatientDrug]) extends Learnable(patientDrug) {
     def label = drugResponse
     override def feature = using(inputFeatures)
     override lazy val classifier = new StochasticGradientDescent
 }
danyaljj commented 8 years ago

@bhargav This is a little weird; this is opened by Parisa, but I don't see her commits here; Specifically when I click on my comments I see pieces of her changes, although they don't seem to exist in the actual PR. I suspect we had a wrong merge here ...

danyaljj commented 8 years ago

But the weird thing is that I don't see her commits here ...

bhargav commented 8 years ago

Hmmm...Yeah somehow the description and the commits do not match. It could be that the branch the PR was sent from was updated completely. Anyways I reviewed the Logging related code and merged those. The final PR was somehow from danyaljj/logger branch into saul/master somehow :/

danyaljj commented 8 years ago

Yeah I was surprised when you merged it because I didn't remember my comments being addressed; however when I looked inside it, i didn't see any of the original changes ... Fortunately it hasn't introduces any unintentional destructive changes. Pity all the changes lost.