CogComp / saul

Saul : Declarative Learning-Based Programming
Other
64 stars 18 forks source link

Logger for Saul #335

Closed danyaljj closed 8 years ago

danyaljj commented 8 years ago

Closes #276

kordjamshidi commented 8 years ago

Why we should extend classes with logging now? We could easily import import org.slf4j.{ Logger, LoggerFactory } and use the predefined levels in there. What is the advantage of your new style?

danyaljj commented 8 years ago

This is a popular was of using external libraries; the pros are:

kordjamshidi commented 8 years ago

To me it looks just fancy :-), but ok for me to merge.

bhargav commented 8 years ago

Looks fine. Will merge when Semaphore run completes.