Closed danyaljj closed 8 years ago
Why we should extend classes with logging now? We could easily import import org.slf4j.{ Logger, LoggerFactory }
and use the predefined levels in there. What is the advantage of your new style?
This is a popular was of using external libraries; the pros are:
sl4j
, LoggerFactory
, etc this is simpler to just add extend Logging
(just like how they add extend DataModel
or extend Learnable
, etc). To me it looks just fancy :-), but ok for me to merge.
Looks fine. Will merge when Semaphore run completes.
Closes #276