search

CogComp / saul

Saul : Declarative Learning-Based Programming
Other
64 stars 18 forks source link

Relation extraction on ACE - 2005 #350

Closed bhargav closed 7 years ago

bhargav commented 8 years ago

Classifiers used:

Replaces PR #187 Cannot update the older one due to a different fork repo.

kordjamshidi commented 8 years ago

Is this with the new features? how are the results?

bhargav commented 8 years ago

These are with older features on ACE2005 dataset. Will update with features used by Zefu and see if we get improvements. Can send that as a separate PR.

kordjamshidi commented 8 years ago

Do you meant to merge this beforehand? why don't you push all here?

kordjamshidi commented 8 years ago

Is this ready for review and merge?

danyaljj commented 8 years ago

I think it's ready. I'll go over it over the weekend; feel free to comment.

kordjamshidi commented 8 years ago

Ok, thanks, I'll review it too.

bhargav commented 8 years ago

I think I will undo the Word2Vec Features commit. The performance went down when they were included. I think it could be due to some issue in Saul when we mix Discrete features and Real Features. Will investigate over the weekend.

kordjamshidi commented 8 years ago

@bhargav I guess your plan was to use the TextAnnotation here for this task as well to have a more uniform NLP data model for various tasks. Are you going to make this change before merging this PR?

bhargav commented 8 years ago

I have updated the code to use TextAnnotation and the ACEReader from CoreUtils. But feature extraction still uses the SemanticRelation class from the older code. I can try to update that to use Edison based features. But I may not be able to work on them for a few weeks.

kordjamshidi commented 8 years ago

Thanks, I think we better to wait and merge the version with your final changes then.

bhargav commented 7 years ago

Closing this old PR.

Instead of bloating the Saul repository, I moved the changes in this PR to a separate repository. Will make fixes/changes there.

New Destination: https://github.com/bhargav/saul-relation-extraction

danyaljj commented 7 years ago

If we're sure that this will be functional, why not move to the CogComp repo?

bhargav commented 7 years ago

Need some more work. Results do not match what was reported in the original paper or SOTA. Will take out some time weekly to debug the features and issues.

bhargav commented 7 years ago

Also. We can definitely move it under CogComp organization. I'll do it once I verify it is fully functional.