Adding some documentation to classes and cleanup

CogComp / saul

Saul : Declarative Learning-Based Programming

Other

64 stars 18 forks source link

Closed bhargav closed 8 years ago

bhargav commented 8 years ago

Major changes:

danyaljj commented 8 years ago

Done with first round of comments. Will go over it again when you complete it.

danyaljj commented 8 years ago

@kordjamshidi plz let @bhargav know if you have any comments on it. Otherwise I plan to merge it tmrw.

kordjamshidi commented 8 years ago

Ok. I am going to look at it tonight.

kordjamshidi commented 8 years ago

Apart from the very few questions I had, it is ok with me to merge.

kordjamshidi commented 8 years ago

@danyaljj I guess @bhargav wanted to make a few more edits before merging.

danyaljj commented 8 years ago

oops sorry I didn't realize it. @bhargav maybe send the edits in another PR? (Revert would create extra commits. And I don't want to do hard reset).

kordjamshidi commented 8 years ago

Yes, lets leave them for another PR.