search

CogComp / saul

Saul : Declarative Learning-Based Programming
Other
64 stars 18 forks source link

SpRL example #383

Closed Rahgooy closed 8 years ago

Rahgooy commented 8 years ago

SpRL example using Saul

bhargav commented 8 years ago

The CI failed due to a recent change in master that removes SparseNetworkLBP class. Look for the SparseNetworkLearner usage in SRL or Entity Relation Example and update the usage accordingly.

Also the format check failed on some new files. You can run sbt format to fix that issue.

Rahgooy commented 8 years ago

Yea, Sure

kordjamshidi commented 8 years ago

why semaphore is failing @Rahgooy? For me this is almost ready to merge. Please review @danyaljj or @bhargav.

bhargav commented 8 years ago

One minor thing that can be fixed later:

Otherwise the changes look fine.

Rahgooy commented 8 years ago

Feature names are the same names that used in the original paper.