search

CogComp / saul

Saul : Declarative Learning-Based Programming
Other
64 stars 18 forks source link

Interactive mode for examples #414

Closed bhargav closed 8 years ago

bhargav commented 8 years ago

Adding interactive mode for a few examples for now.

danyaljj commented 8 years ago

Looks good to me to merge. Merge call with @kordjamshidi

kordjamshidi commented 8 years ago

It was just unexpected, this PR was made two days ago for the interactive annotator and then there are other changes irrelevant here from old issues.

kordjamshidi commented 8 years ago

@bhargav

bhargav commented 8 years ago

I was getting error when using the propertyWithin properties. I can debug and see if I can remove these changes and separate them.

kordjamshidi commented 8 years ago

I see, now makes sense. But then why the number of features reduced a bit? Yes, it would be great if you could debug it and see what is happening.

bhargav commented 8 years ago

Thanks. Will investigate this further.

kordjamshidi commented 8 years ago

this is one thing we need to merge this morning.

bhargav commented 8 years ago

So the issue was happening because propertyWithin based features are not recalculated when the datamodel graph is re-populated. They just enumerate features once (and on the initial graph). Hence I was getting error when I repopulate graphs in interactive mode. That issue is fixed now.

Looking at the unit test. Otherwise the code is ready for review.

kordjamshidi commented 8 years ago

Please merge when Semaphore is happy @bhargav

danyaljj commented 8 years ago

Merge upon green!