search

CogComp / saul

Saul : Declarative Learning-Based Programming
Other
64 stars 18 forks source link

Adds a programmer workflow to the Documentation #440

Closed kordjamshidi closed 8 years ago

kordjamshidi commented 8 years ago

We need to work more on the documentation: I was surprised to see we did not have any information about how to call test and train over classifiers in the current documentation, so I dded some.

kordjamshidi commented 8 years ago

Can someone review this? should be quick. @bhargav @danyaljj

kordjamshidi commented 8 years ago

Why semaphore is complaining?

danyaljj commented 8 years ago

It's not Semaphore. It's anther CI for testing on Windows OS. Almost surely has nothing to do with this PR. @bhargav will probably address it at some point.

kordjamshidi commented 8 years ago

ah, ok, so please merge then if this PR is ok.

bhargav commented 8 years ago

I was testing out CI for Windows. Enabled it on the main repo by mistake. Was testing it on my fork. Semaphore build passed.

Yeah. It currently fails on Windows due to the header plugin. Will enable on this repo when it is ready.

danyaljj commented 8 years ago

Just two remaining comments (code indentation, and number of the items in the root readme), and then good to merge.

kordjamshidi commented 8 years ago

do you mean by code indentation here? thanks for the point, fixed the numbering.

kordjamshidi commented 8 years ago

Markdown preview looks weird in my Intellij and I can not see the correct spacing but try to fix.