search

CogComp / saul

Saul : Declarative Learning-Based Programming
Other
64 stars 18 forks source link

Added MultilayerPerceptron #481

Closed Abi1024 closed 7 years ago

Abi1024 commented 7 years ago

Multilayer Neural Network implementation for Saul, with support for sparse feature vectors, various activation functions and L-2 regularization.

kordjamshidi commented 7 years ago

Thank you very much @Abi1024 . @bhargav @danyaljj please review at your earliest convenience.

danyaljj commented 7 years ago

Looks (almost) good to me. Passing it to @bhargav for a final look.

Abi1024 commented 7 years ago

Hi, I just incorporated all of @bhargav 's suggestions and also added regression for the facebook circumplex dataset. If someone could take a look sometime, that would be much appreciated. Thanks!

kordjamshidi commented 7 years ago

@bhargav please see if this is ok with the recent changes. However, I am not sure if we want to merge the new app of circumplex (sentiment analysis) model also into Saul. @Abi1024 can remove that application, maybe, and just keep the implementation of the Learners. Let him know if removing the App is preferred @danyaljj @bhargav .

kordjamshidi commented 7 years ago

Oh, I see @bhargav has approved the changes already. So we merge the app too? Any opinion, comments?

danyaljj commented 7 years ago

Agreed. Unless the application is complete (fully functional, with readme etc), I would rather not checking it in.

kordjamshidi commented 7 years ago

Thanks @Abi1024 for removing the app, I m going to merge then.