search

CogDisResLab / drugfindR

Repository holding the code for the drugfindR R package
GNU General Public License v3.0
8 stars 3 forks source link

Migrate to httr2 #22

Closed AliSajid closed 1 month ago

AliSajid commented 1 year ago

Related Issues:

  1. ropensci/webmockr#122
  2. ropensci/vcr#237

Since httr has been deprecated, it would be a good idea to migrate to httr2 for compliance.

A blocker right now is that we rely on vcr and webmockr for some of our tests. Once the above issues are resolved we should move to httr2.

sckott commented 1 year ago

Sorry about the hold up on httr2 integration - I can't promise a date when it will be done, but I'm hoping to get back to it soon

sckott commented 3 months ago

Both vcr and webmockr now support httr2 with the latest versions of each pkg on cran. Let me know if you run into any issues

AliSajid commented 3 months ago

@sckott Woohoo! Thank you for all the work! I'll be running tests on this soon. This made my day. :)

sckott commented 3 months ago

great!