search

CogDisResLab / drugfindR

Repository holding the code for the drugfindR R package
GNU General Public License v3.0
8 stars 3 forks source link

Store the vignette data in a local file #36

Closed AliSajid closed 6 months ago

AliSajid commented 9 months ago

Here's the reviewer's comment:

Vignette code should be self-contained. It is not. diffexp <- read_tsv("https://zenodo.org/records/10265182/files/dCovid_diffexp.tsv")

Packages that rely on access to web resources need to be written carefully. Web resources can change location, can be temporarily unavailable, or can be very slow to access and retrieve.

The easiest way to fix this is to store the data in a local file and use that file in the vignette. This is a common practice in R/Bioconductor packages.

We just need to make sure that the file size is not large.