search

CogentRedTester / mpv-scroll-list

MIT License
36 stars 3 forks source link

scroll-list.lua bugs if multiple scripts active #7

Open KonoVitoDa opened 9 months ago

KonoVitoDa commented 9 months ago

I'll try to explain the bug behavior, but it's kinda confusing:

  1. Start mpv.exe and play mkv file
  2. Open sub track list (Ctrl+s script-message-to track_list toggle-subtrack-browser)
  3. Everything is fine, mouse and keyboard controls works; WHEEL_UP/DOWN navigates through subs, MBTN_LEFT selects track, MBTN_RIGHT hides list, etc.
  4. Exit sub track list with ESC
  5. Open chapters list (c script-message toggle-chapter-browser)
  6. No keybinds working anymore, WHEEL_UP/DOWN changes volume, ESC doesn't close the list; MBTN_LEFT cycles pause instead of selecting track, MBTN_RIGHT opens uosc's context menu; and yet more, uosc's buttons (playlist manager on top-left, and window controls on top-right) stops to work as well

PS.: The bug also occurred in the step 3 a few times

I ran several tests trying to find if the bug was caused by any specific script, but its behavior was totally randomic, and seems to depend more on the amount of scripts active at the same time than on which scripts they are, so I couldn't find any pattern, and therefore I needed to share my entire scripts+script-modules folder in case you want to run tests with it as well. Of course, I also ran tests with no mpv.conf and input.conf. This bug only seems to occur when all these scripts are in the folder, if I remove a seemingly unrelated script, like clipshot.lua for example, it stops occurring; if I remove gallery.lua from script-modules, it also stops occurring, but if I leave only scroll-list.lua and gallery.lua in the script-modules folder, the bug stops occurring again, so I simply can't identify what's causing the bug, seems something totally random.

Verbose (-v -v): log.txt

scripts / script-modules: image image

KonoVitoDa commented 8 months ago

Were you able to reproduce the steps? Should I report this issue on mpv's official repository too?

CogentRedTester commented 8 months ago

I haven't had time to try and reproduce it yet. Ping me again if I haven't responded in a week.

KonoVitoDa commented 7 months ago

@CogentRedTester

CogentRedTester commented 7 months ago

@KonoVitoDa your log file and mega file have expired, could you upload them again? Anyway, this bug seems rather bizarre. I can only assume that some other scripts are overwriting the scroll list keybinds.

If you're using a somewhat recent version of mpv then you can see the currently set keybinds in the fourth page of the stats screen. If you scroll down you should be able to find a section called script: chapter_list. This section is only available while the chapter list is visible, and it will show which keybinds are available. If another script has overwritten a chapter-list keybind, then that keybind will disappear from the chapter-list section. If you scroll through the full list you should be able to find what has overwritten the keybind.

Do this, and let me know what you find.

KonoVitoDa commented 7 months ago

The log file link was still working for me, but I've uploaded it again, and I also updated the MEGA link.

CogentRedTester commented 7 months ago

Can you also try the steps I outlined with the stats page?

KonoVitoDa commented 7 months ago

Can you also try the steps I outlined with the stats page?

I finally did it (sorry for the long delay) and the only thing I was able to find is that the aforementioned keys are bound to its defaults commands, not the script ones.

Well, nevermind, if you are not able to reproduce the bug yourself, then let it be, it's not a big deal after all.