search

CogentRedTester / mpv-sub-select

An advanced conditional subtitle track selector for mpv player
MIT License
89 stars 8 forks source link

Simplify sub-select.json #5

Closed teohhanhui closed 3 years ago

teohhanhui commented 3 years ago

It is functionally equivalent, right?

CogentRedTester commented 3 years ago

It is equivalent, yes. However, the thing is that I don't really want to promote that format in the json file. That feature was implemented by someone else, and I somewhat regret accepting it because it means that subtitle precedence is determined in more than one place, which makes the config file harder to follow and read. Ideally, I would like to change the behaviour so that the order of subtitles in that array has the exact same priority, and whichever is in the file first is selected, but I'm a little worried that it may break people's configs. I might still do it at some point though.

You have convinced me to modify the documentaton and example json to remove the example of that format that I did when I originally merged it.

Thanks for the patch offer though.

teohhanhui commented 3 years ago

Hmm. I completely disagree. It's much more readable this way, instead of repeating the same block for multiple languages when you actually want to just treat them the same way.

CogentRedTester commented 3 years ago

Well then I'll be leaving the feature the way it currently is.