CognitiveAtlas / ontology

Repository for the ontology and discussion/issue with ontology content
MIT License
4 stars 1 forks source link

Duplicate terms #1

Open tsalo opened 7 years ago

tsalo commented 7 years ago

I don't think there's a way to delete terms as a user, so here are a few duplicates that need to be resolved (assuming this is the right place to bring them up):

Also, the concepts dyslexia, surface dyslexia, and conduct disorder should all be disorders, I think.

poldrack commented 7 years ago

thanks Taylor! I think we will wait until the new database is in place (hopefully within a couple of weeks) since removing things from the current database is a PITA

On Tue, Sep 12, 2017 at 1:09 PM, Taylor Salo notifications@github.com wrote:

I don't think there's a way to delete terms as a user, so here are a few duplicates that need to be resolved (assuming this is the right place to bring them up):

Also, the concepts dyslexia http://www.cognitiveatlas.org/concept/Dyslexia, surface dyslexia http://www.cognitiveatlas.org/concept/id/trm_55e1b27f5655e, and conduct disorder http://www.cognitiveatlas.org/concept/conduct_disorder should all be disorders, I think.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/CognitiveAtlas/ontology/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/AA1KkJcU47Tel8J0rOmnoQ6CToF48qv2ks5shuTmgaJpZM4PVLZy .

-- Russell A. Poldrack Albert Ray Lang Professor of Psychology Professor (by courtesy) of Computer Science Bldg. 420, Jordan Hall Stanford University Stanford, CA 94305

poldrack@stanford.edu http://www.poldracklab.org/

cestinson commented 7 years ago

On the last point, currently Disorders doesn't include much beyond what's in the Disease Ontology's diseases of mental health, which follows the structure of ICD 10. Adding surface dyslexia as a disorder would make disorders no longer match the ICD 10 structure. Seems worth thinking about whether that's desirable, and if so, where to put the additions. Everything classified in ICD 10 as a brain disorder isn't included, but many probably should be.

Conduct disorder and dyslexia do appear as Disorders already, but neither is connected to its associated concept. Same thing for anxiety and anxiety disorder. It might be worth considering keeping these as both concepts and disorders, but making sure they're connected somehow.

poldrack commented 7 years ago

After discussion with @KateBlackThorn we have affirmed the previous policy that disorders are not to be linked directly to concepts. instead, the linkage should go through a task. the point is to make clear that we require direct evidence for such a linkage - simply saying that anxiety disorders involve the concept of anxiety is not enough, we need to show how that link is actually established empirically

tsalo commented 7 years ago

I know this is a little delayed, and also a bit of a departure from the original issue, but does that mean that disorders will be more editable?

Also, should disorders link to concepts through tasks directly, or would it be better to link disorder symptoms to the concepts through the tasks?

poldrack commented 7 years ago

we are planning to have disorders link to concepts via task contrasts - the idea being that the link between the disorder and the task would be established empirically, and then the link between the task and concept would proceed as usual.

symptoms could also be linked to tasks - I think the most appropriate way to do that would be to have symptoms link to specific measurements (which would be listed under "tasks") and and then link to concepts that way. does that sound reasonable?

yes, disorders should be editable in the new release cheers russ

On Thursday, October 26, 2017, Taylor Salo notifications@github.com wrote:

I know this is a little delayed, and also a bit of a departure from the original issue, but does that mean that disorders will be more editable?

Also, should disorders link to concepts through tasks directly, or would it be better to link disorder symptoms to the concepts through the tasks?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/CognitiveAtlas/ontology/issues/1#issuecomment-339669635, or mute the thread https://github.com/notifications/unsubscribe-auth/AA1KkJvOhSA_0pV1D0jN2HmZ-SfHuSFdks5swIwbgaJpZM4PVLZy .

-- Russell A. Poldrack Albert Ray Lang Professor of Psychology Professor (by courtesy) of Computer Science Bldg. 420, Jordan Hall Stanford University Stanford, CA 94305

poldrack@stanford.edu http://www.poldracklab.org/

tsalo commented 7 years ago

That sounds great

cestinson commented 7 years ago

For some uses it might be important to be able to distinguish diagnostic symptoms from other measures/tasks. They may also have a systematically different relationship to the evidence; it's a very particular kind of study that looks at whether a clinical population does indeed have the symptoms used to diagnose them in the first place. One way around this might be to use diagnostic manuals in addition to research papers as the references for these tasks. I'm not sure if this is a problem or not.

KateBlackThorn commented 7 years ago

@cestinson would adding a kind of 'weight' between disorder and symptom based on a metric of the supporting references fit this need?

KateBlackThorn commented 7 years ago

@cestinson To be clear: meaning that the weight would indicate how confidently/specifically the symptom could diagnose the disorder. @poldrack and I have been discussing including a project we are working on to code individual measures/items in the listed tasks/scales with the symptoms/traits they measure. There are a variety of beneficial use cases for this level of granularity. You point out another possible one here in that such information be used readily to see which symptoms are currently being used most specifically to diagnose one disorder over another...as an alternative means to weight the symptom-disorder relationship.

cestinson commented 7 years ago

Sounds like that might work. I don't think I'm far enough along on what I'm working on to say for sure at this point. One thing I like about it is that it allows diagnostic symptoms to have a different status, but also for that status to be defeasible.