Closed motevallian closed 7 years ago
Good pickup @motevallian . Do you think we need to even offer this choice anymore? I'm thinking we default it to ".html" and maybe set the loader test to \.html?
. That will find files that end in .htm
and .html
.
@motevallian thoughts (see above)?
I think the thing that matters is to be consistent, if we give a choice to the user, he expects his selection to be reflected eveywhere.
So, if he is able to enter anything, we should add that very same string to the loader config. Otherwise, making it to choose between htm
and html
is also fine.
Thanks @motevallian. I'll fix this by removing the choice in the UI and making the config support .htm and .html
During generating an app using confit, if I select
.htm
for the extension of my html files, then I request a sample app to be generated, any command trying to run Webpack will fail. For example when I try to bundle the app I get this:As I have a bit of experience with Webpack I knew the
html-loader
is not picking up those files and could immediately look and fix it but I am sure it will take sometime for a newbie to figure out why the sample app does not work (Rememberpage1
andpage2
have their extension hardcoded as.html
). I recommend changing the type of those file according to the Confit configs.