search

Cognizant-CDE-Australia / generator-confit

Build-tool generator for current and future web.
https://odecee.github.io/generator-confit
Other
29 stars 3 forks source link

Feature/css regression tests #80

Closed uglow closed 8 years ago

uglow commented 8 years ago

Add visual regression testing, added unit tests, starting to simplify YAML config.

uglow commented 8 years ago

Hi @Nighthawk14, are you able to code review and run this locally, please? Dan Proud suggest moving the reference images into a directory that would be checked-in, so that the tests could be run on CI. I'm still using the same version (1.3.5?) of Backstop rather than the beta-2 version, and the command to run is test:visual and test:visual:ref.

I've added unit tests but will not add integration tests yet (I just want to get this out first).

Nighthawk14 commented 8 years ago

@uglow I just finished running the tests locally. I have the same error as on Jenkins for the first one. The others are fine :)

uglow commented 8 years ago

@Nighthawk14 I've just pushed another commit which should fix the failing test. Basically NodeJS doesn't have any config for testVisualRegression, so it complains when it uses EJS to parse the npmResources.yml file.