CohenLabPrinceton / pvp

Raspberry pi code for controlling the rapid-deploy critical care ventilator
GNU General Public License v3.0
13 stars 15 forks source link

This removes PEEP control, and wires up the controller with the hardware #106

Closed mschottdorf closed 4 years ago

mschottdorf commented 4 years ago
  1. Fixed the hardware issues, i.e. correct pressure measurements.
  2. Allows closed loop PID and state control.
  3. Default is PID control (seems to work better). On the dinky with these results:

image

Note: Installed was a 5 cm H2O PEEP valve, so this is not software controlled.

This is from a different run, where you can see control-in, and fast out image

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 422


Changes Missing Coverage Covered Lines Changed/Added Lines %
vent/controller/control_module.py 30 55 54.55%
<!-- Total: 33 58 56.9% -->
Files with Coverage Reduction New Missed Lines %
vent/controller/control_module.py 1 73.38%
vent/gui/widgets/status_bar.py 4 66.3%
<!-- Total: 5 -->
Totals Coverage Status
Change from base Build 407: -0.6%
Covered Lines: 2652
Relevant Lines: 3322

💛 - Coveralls
zajdel commented 4 years ago

Results look very nice. Looks like you're hitting the PIP fast and reliably!

zajdel commented 4 years ago

Also physically tested on the Dinky. I would say this is ready to merge.