Closed mschottdorf closed 4 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
vent/controller/control_module.py | 30 | 55 | 54.55% | ||
<!-- | Total: | 33 | 58 | 56.9% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
vent/controller/control_module.py | 1 | 73.38% | ||
vent/gui/widgets/status_bar.py | 4 | 66.3% | ||
<!-- | Total: | 5 | --> |
Totals | |
---|---|
Change from base Build 407: | -0.6% |
Covered Lines: | 2652 |
Relevant Lines: | 3322 |
Results look very nice. Looks like you're hitting the PIP fast and reliably!
Also physically tested on the Dinky. I would say this is ready to merge.
Note: Installed was a 5 cm H2O PEEP valve, so this is not software controlled.
This is from a different run, where you can see control-in, and fast out