CohenLabPrinceton / pvp

Raspberry pi code for controlling the rapid-deploy critical care ventilator
GNU General Public License v3.0
13 stars 15 forks source link

Fixing relative path loads in `io` #137

Closed sneakers-the-rat closed 4 years ago

sneakers-the-rat commented 4 years ago

While i was seeing if the 'data' folder was being used in the code, i found that there was a place in io where a relative path was used that would fail if the package wasn't being run from the repository root (ie. in cases where one installs from PyPI or etc.). The real way to do this would be to have a CALIBRATION_DIR in prefs that allows the user to set where their calibration files are, but this PR does some basic path safety stuff:

before i merge i wanted to make sure with y'all that this doesn't break the actual system

mschottdorf commented 4 years ago

makes sense & looks good to me

mschottdorf commented 4 years ago

looks good to me; ready to merge

sneakers-the-rat commented 4 years ago

ok pulled changed from master to this branch and will merge if tests pass