CohenLabPrinceton / pvp

Raspberry pi code for controlling the rapid-deploy critical care ventilator
GNU General Public License v3.0
13 stars 15 forks source link

Implementation of ControlModuleDevice using HAL #51

Closed mschottdorf closed 4 years ago

mschottdorf commented 4 years ago

This is a draft implementation of the ControlModuleDevice.

I've added a few stubs to HAL, that is (1) flow measurements on expiratory and inspiratory side (to calculate End-Tidal Volume) and (2) flow control on expiratory and inspiratory side (the prop valve and solenoid).

Without any tests :-)

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 167


Changes Missing Coverage Covered Lines Changed/Added Lines %
vent/controller/control_module.py 4 31 12.9%
vent/io/hal.py 23 74 31.08%
<!-- Total: 27 105 25.71% -->
Files with Coverage Reduction New Missed Lines %
vent/controller/control_module.py 2 91.34%
<!-- Total: 2 -->
Totals Coverage Status
Change from base Build 141: 5.6%
Covered Lines: 851
Relevant Lines: 2338

💛 - Coveralls
CommReteris commented 4 years ago

Ideally I think this should be pulled into hardware-dev instead of master