CoherentStructures / CoherentStructures.jl

Tools for computing (Lagrangian) coherent structures objectively in Julia
Other
22 stars 10 forks source link

No elliptic barrier found #98

Closed lunahiron closed 1 year ago

lunahiron commented 1 year ago

Hi everyone,

I have used the CoherentStructure code in the past to find Lagrangian coherent contours from an altimetry-derived velocity field, and it worked fine. However, I updated all libraries last week; the code ran fine, but no elliptic barrier was identified for the same dataset.

I then tried to run the ocean_flow.jl (example), and the problem persists: no elliptic barrier is identified. Please, see below the results for both my analysis and the ocean_flow.jl example.

I am using Julia v1.8.5 and CoherentStructures v0.4.11.

Do you have insights on what could be happening? Thank you!

my_analysis ocean_flow_example
dkarrasch commented 1 year ago

I am working on an internal update that accounts for changes in the ecosystem. Looks like breaking changes have been done without bumping the major version number, or, we use features of other packages that are considered too internal to warrant a major version bump.

dkarrasch commented 1 year ago

Thank you for triggering the internal update @lunahiron. At least the docs work properly again, and I think I found the source, so hopefully things will be alright also on your end. If not, please reopen the issue and we'll investigate.

I'll wait to see if the docs build correctly and then tag a new release. If all goes right, this will be in less than an hour.

lunahiron commented 1 year ago

Hi Daniel, I installed the internal branch and the code is running and working well. I was able to find the elliptic barriers. Thanks a lot for this quick fix!!

dkarrasch commented 1 year ago

I released a new version. You should now safely return to the default setting, as I'm going to remove the internal branch.