search

CoinAlpha / gateway-api

Apache License 2.0
47 stars 25 forks source link

Feat/uni v3 ite 2 #102

Closed vic-en closed 3 years ago

james-hummingbot commented 3 years ago

This looks good. I've already went over it with Victor, but I will be converting it into Typescript today because of changes that will be introduced by https://github.com/CoinAlpha/gateway-api/pull/100

james-hummingbot commented 3 years ago

I changed some of the code to typescript. This should be re-reviewed by either @CrimsonJacket or @CoinAlpha/qa-team

PtrckM commented 3 years ago

@james-hummingbot last 3 commits https://github.com/CoinAlpha/gateway-api/pull/102/commits/d3eb88dd41d373d395d58ba4eee06c4c35f4285c https://github.com/CoinAlpha/gateway-api/pull/102/commits/20e5db8f997b68dfb190215036c0aa67612077ff https://github.com/CoinAlpha/gateway-api/pull/102/commits/89190311abac6295f85fac5d329ce94c390861df causing:

image image image

james-hummingbot commented 3 years ago

@CoinAlpha/qa-team I've fixed the first problem you've mentioned incorrect balance. The second issue is happening probably because you do not have enough ETH to cover the fees (using uniswap v3 is quite expensive). This isn't really an issue on the gateway side, maybe we could improve the messaging on the hummingbot client side.