search

CoinAlpha / gateway-api

Apache License 2.0
47 stars 25 forks source link

Simplify Uniswap v2 strategy #114

Closed fengtality closed 2 years ago

fengtality commented 2 years ago

The current Uniswap V2 connector caches multiple pools and refreshes them every 5 minutes in order to find the best route. While this approach might be optimal, it's much more complex and prone to failure.

I created a new branch that uses the Uniswap SDK quickstart pricing method for Uniswap, which is much simpler. This branch also implements. TokenList lookup for both kovan and mainnet. Let's discuss on Monday.

fengtality commented 2 years ago

As discussed in standup, please complete the refactor / simplification of the Uniswap connector started in https://github.com/coinalpha/gateway-api/tree/mf-uniswap.

When I tested this with the AMM ARB strategy in Hummingbot, the trade endpoint didn't work (see logs logs_conf_amm_arb_1.log), so there may be some additional changes needed.