Closed vic-en closed 3 years ago
Sorry @vic-en for trampling all over your PR... I should have created a separate branch for the last 2 commits. I don't think they affected the Uniswap part of the code, but feel free to roll them back if you want.
I think the buy
function in Uniswap may still throw an error, though I was testing using Postman and not with the client.
Sorry @vic-en for trampling all over your PR... I should have created a separate branch for the last 2 commits. I don't think they affected the Uniswap part of the code, but feel free to roll them back if you want.
I think the
buy
function in Uniswap may still throw an error, though I was testing using Postman and not with the client.
I figured it. I'd push a commit to address that.
I added a commit which:
maxSwaps
that sets the number of swaps used.Smaller traders would use a small maxSwaps number because they care more about gas costs, while larger traders would use a high maxSwaps because they want the best price and don't care about gas as much. We should factor this calculation into the client profitability calculation as well: